pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Fix "undo" operation erroneously removing the dirty flag when undo operation performed after saving

Open fmqa opened this issue 3 years ago • 3 comments

Fixes #11649

This makes sure that the editor is always marked "changed" after an undo operation.

fmqa avatar Sep 06 '22 19:09 fmqa

I will test this on my development image for a some time to make sure nothing breaks by accident before marking it ready

fmqa avatar Sep 06 '22 19:09 fmqa

CI fails due to #11657 Edit: Seems that this is no longer the case as of 8381e90cf9511d6bc5f0a04c8b589e06ec809d2b

fmqa avatar Sep 07 '22 18:09 fmqa

Failing tests not related:

  • [CI] Failing test: ProperMethodCategorizationTest>>testNoUncategorizedMethods #11669
  • [CI] Failing test: ReleaseTest>>testUndeclared #11670
  • #skipOnPharoCITestingEnvironment seems to not work on WIN and MAC #11425

MarcusDenker avatar Sep 12 '22 11:09 MarcusDenker

This solution works for me.

NSUSpray avatar Oct 04 '22 07:10 NSUSpray