pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Review RBLiteralNode class>>#value:

Open astares opened this issue 3 years ago • 1 comments

  • RBLiteralNode class>>#value: checks for the class using equality

shouldnt it check for #isArray or #isByteArray to find out if it should use RBLiteralArrayNode or RBLiteralValueNode?

I know that the #isByteArray is not yet in the image, but we can easily add it.

astares avatar Aug 29 '22 00:08 astares

the problem is that there are subclasses of ByteArrray that are not supposed to be a RBLiteralArrayNode. it is really just that class.

MarcusDenker avatar Sep 07 '22 07:09 MarcusDenker