pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Copy class refactoring should copy the class comment

Open Ducasse opened this issue 3 years ago • 4 comments

When copying a package the classes lose their comments.

Ducasse avatar Aug 13 '22 20:08 Ducasse

We changed this already 2 times (maybe even more often): we changed to copy the comment, then we decided that it is bad and removed it again.

Maybe we should add a checkbox to the dialog, then people can copy the comment if they are sure it is what they want.

MarcusDenker avatar Aug 15 '22 08:08 MarcusDenker

see https://github.com/pharo-project/pharo/pull/5390

MarcusDenker avatar Aug 15 '22 08:08 MarcusDenker

I do not see why not copying is needed. Losing information is always bad. After when we copy this is either to remove the original ones or to modify the result and in this case we should go over the comment but going over a comment is better than Oops there is not comment.

Ducasse avatar Aug 15 '22 11:08 Ducasse

I strongly disagree with #5390.

Ducasse avatar Aug 15 '22 11:08 Ducasse