pharo icon indicating copy to clipboard operation
pharo copied to clipboard

#skipOnPharoCITestingEnvironment seems to not work on WIN and MAC

Open MarcusDenker opened this issue 3 years ago • 4 comments

Bug description testJobIsFinishedWhenWaitingMoreThanWorkBlockDuration is failing on win even thought it does

" self skipOnPharoCITestingEnvironment."

This is related to environment variables:

onPharoCITestingEnvironment
	
	^ Smalltalk os environment at: 'PHARO_CI_TESTING_ENVIRONMENT' ifPresent: [ true ] ifAbsent: [ false ]

MarcusDenker avatar Jun 30 '22 09:06 MarcusDenker

on MAC, too:

SpJobListPresenterTest>>#testJobIsFinishedWhenWaitingMoreThanWorkBlockDuration

was failing even though it is skipped

MarcusDenker avatar Jun 30 '22 11:06 MarcusDenker

What is odd: if skipOnPharoCITestingEnvironment would not work, we should see much more tests failing.

MarcusDenker avatar Jun 30 '22 11:06 MarcusDenker

I checked the CI: the variable was not defined globally, I added it back

MarcusDenker avatar Jul 14 '22 12:07 MarcusDenker

Still not working correctly

MarcusDenker avatar Jul 18 '22 10:07 MarcusDenker

After adding it to the global config had no effect, I added the environment variable to all the CI machine runner setups

MarcusDenker avatar Aug 18 '22 07:08 MarcusDenker

The test testJobIsFinishedWhenWaitingMoreThanWorkBlockDuration does not have #skipOnPharoCITestingEnvironment...

so it seems the mechanism works, but some methods miss the tag.

MarcusDenker avatar Sep 14 '22 09:09 MarcusDenker