pharo icon indicating copy to clipboard operation
pharo copied to clipboard

Cleanup: use #isNotEmpty instead of #notEmpty

Open astares opened this issue 2 years ago • 0 comments

We have many implementors of #isNotEmpty:

image

but we have also implementors of #notEmpty

image

The "isSomething" or "isNotSomething" is usually the better style within the method category "testing".

So we should

  • convert all #notEmpty into #isNotEmpty
  • deprecate the #notEmpty methods
  • write a rule to check method selectors to point the user to the fact that it is better to prefix "notSomething" into "isNotSomething"

astares avatar May 30 '22 17:05 astares