[improvement] better default hierarchy display

[hogoww]

Fixes #11052 One of those settings we don't know about ! :D

[MarcusDenker]

Failing test:

Error
Given Collections do not match!  additions : an Array(a StoredSetting('#Calypso#isDefaultHierarchyForMethodVisibility'))  missing: #()
Stacktrace
TestFailure
Given Collections do not match!
	additions : an Array(a StoredSetting('#Calypso#isDefaultHierarchyForMethodVisibility'))
	missing: #()
SystemSettingsPersistenceTest(TestAsserter)>>assert:description:resumable:
SystemSettingsPersistenceTest(TestAsserter)>>assert:description:
SystemSettingsPersistenceTest(TestAsserter)>>assertCollection:hasSameElements:
SystemSettingsPersistenceTest>>testDefaultImageDoesNotStoreAnySetting
SystemSettingsPersistenceTest(TestCase)>>performTest

[hogoww]

After investigation, it's because the setting in the setting browser is different from the one that is defined in the method. I am unsure of where the setting browser is initialised however

[hogoww]

After investigation with @demarey there seems to be an old config file that is taken into account although it should. We should probably add the --no-preference flag to the Travis file, I was asked to ping @tesonep about it.

[hogoww]

As asked by @estebanlm, changed target to p11

[hogoww]

same failing test. see previous comment

[hogoww]

We fixed the test case that was failing with @demarey on this sprint to not use the current system but rather a mock. We should now be able to change default parameters more easily.

[hogoww]

Where is pre-selection of currently used class? You want to have it in separate PR?

I was planning to investigate this on the sprint following the integration of this PR. But it's been a while. With Iona, we send a mail about this to see if people had a preference about this: https://lists.pharo.org/empathy/thread/HTIE7ZPSIUTBWL5T5SBAVTWZKCU2VN7H

Empathy List Archives

Empathy mailing list archives

[hogoww]

I do not intent to pursue this any further. @MarcusDenker Do you mind reviewing it? It's really just a setting change, and a test update, there's nothing to it... Plus it was already approved by Sebastian.

In the case of big hierarchy, it doesn't seem to matter because it only shows you 2 classes anyway. But at least, they'll be in order, and that tool will finally be usable without me thinking for a minute each time I have to use it.

[MarcusDenker]

I am trying my best to review PRs, but there are just too many for me to be able to promise anything...

[hogoww]

I am trying my best to review PRs, but there are just too many for me to be able to promise anything...

I know, I'm asking specifically for this one because it's super short. It's literally just a default setting change. Couldn't be shorter.

On top of that we had to fix a test case, which I agree is harder to review. But that was Christophe's doing, and he works well =)

[jordanmontt]

Now there are merge conflicts

[hogoww]

Now there are merge conflicts

Solved. It was conflicting because of Astares' recent cleanup wave.