pharo-launcher icon indicating copy to clipboard operation
pharo-launcher copied to clipboard

Adoptions to use refactored version of CLAP

Open Bajger opened this issue 3 years ago • 1 comments

Bajger avatar Jul 12 '22 12:07 Bajger

This is super cool to get your help to improve CLAP thanks a lot.

Ducasse avatar Oct 20 '22 07:10 Ducasse

@demarey Hi Christophe! I think I've finally made all necessary changes to use new CLAP! Please take a review and let me know. Some insights:

  • there is just one failing test at the moment -> PhLImageCreateFromPullRequestCommandTest>>testExecuteFromPR due to fact it relies on Network. Any ideas how to plug PhLImageFinderStub (that would give hardcoded replies) instead of PhLImageFinder
  • PhLImageCreateFromSHACliCommandTest>>testCreateImageFromShaShouldSucceed also relies on Network
  • help command prints default help message for clap command but not for concrete subcommands. Any ideas what might be wrong?

PS: If you don't mind, I'd like to merge PR then.

Bajger avatar Mar 28 '23 07:03 Bajger

@demarey: Incorporated review comments. Now I need to resolve following on CLAP:

  • resolve printHelp problem
  • add convenient method to separate first 3 lines on ClapContext>>executeToExit:, so I can bypass ImageFinder class on command instance in unit tests that rely on network.

Bajger avatar Apr 03 '23 06:04 Bajger