pharo-launcher icon indicating copy to clipboard operation
pharo-launcher copied to clipboard

Fix cleanup of PhLProcessWrapperTest>>testRunningInfiniteProcessThrowsTimeout

Open Bajger opened this issue 2 years ago • 4 comments

Describe the bug PhLProcessWrapperTest>>testRunningInfiniteProcessThrowsTimeout starts infinite loop process, which is never terminated. Tests passes, but never cleans a process, which is still running. This causes noisy Hit CTRL+C output, when running multiple tests.

To Reproduce Steps to reproduce the behavior:

  1. Clone Pharo Launcher
  2. build pharo launcher: PHARO=100 ARCHITECTURE=64 ./build.sh prepare
  3. run: ./pharo-vm/pharo --headless ./PharoLauncher.image test "PharoLauncher-Tests-Functional"
  4. Hit CTRL+C keeps repeating on terminal (caused by testRunningInfiniteProcessThrowsTimeout)

Expected behavior Endless loop process is properly terminated after assertion (see test method).

Version information:

  • OS: Ubuntu Lunux
  • Version: Pharo Launcher 3.0.1

Expected development cost Add to test process terminate in ensure: block?

Bajger avatar May 05 '22 13:05 Bajger

@demarey : Should I remove my commit to not interfere with yours? https://github.com/Bajger/pharo-launcher/commit/7307b2215fb54a4d7627002f8b8d5bad3690ce93

Bajger avatar May 27 '22 08:05 Bajger

Ahh, ignore this PR is already closed.

Bajger avatar May 27 '22 08:05 Bajger

@demarey Should I close this issue? I think fix is only in feature/cmd-line branch, not sure if to cherrypick your fix to main branch?

Bajger avatar Jul 11 '22 13:07 Bajger

the issue will close by itself when the cmd-line branch will be merged in the main branch

demarey avatar Jul 11 '22 14:07 demarey