pharo-launcher icon indicating copy to clipboard operation
pharo-launcher copied to clipboard

Published 20 hours ago • verified publisher icon pharo-project

simplify-conditions

Open jecisc opened this issue 4 years ago • 1 comments

Simplify conditionals

jecisc avatar May 09 '20 22:05 jecisc

The automatic rewrite of isEmpty ifTrue: to ifEmpty: is too simplistic. It implies the receiver is a collection and undestands ifEmpty. A lot of other objects can implement #isEmpty but not necessarly #ifEmpty or #ifNotEmpty.

In this PR, a lot of tests fail because of:

HTTPProgress(Object)>>doesNotUnderstand: #ifNotEmpty:

demarey avatar May 15 '20 12:05 demarey