Default launcher download names seem to cause trouble on Windows

[astares]

If one downloads images with Launcher on Windows and accepts default names like "Pharo 7.0 - 32bit (stable)" this will end up in path names like

"C:/Users/Admin/Documents/Pharo/images/Pharo 7.0 - 32bit (stable)"

The dot and space combination in such files can later make trouble when downloading projects (like Seaside) using Iceberg and libgit.

More details here: http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/2019-April/275028.html

[demarey]

Hi, sorry for the delay. I did not get time to check this issue before.

I made several tests on Windows and I can confirm that there is no problem with names proposed by Pharo Launcher. From the discussion on Pharo ML:

Requires some more testing but I guess it is related to the naming in Pharo Launcher with "dots" AND "spaces" instead of the long filenames.

"pharo 7.0 (stable)" fails "seaside.test" works "seaside test" works also "seaside. test" works also "seaside-test" works also "seaside(test)" works also

From what I see, you did not test in the same conditions. Proposed name 'Pharo 7.0 - 32bit (stable)' has 26 characters whereas 'seaside(test)' has only 13 characters. On my Windows VM, I tested with names of the same length to clone pharo repository:

• "Pharo 7.0 - 32bit (stable)" does not work (26 char)
• "Pharo 700 - 32bit (stable)" does not work (26 char, no dot)
• "Pharo 7Z0 - 32bit ZstableZ" does not work (26 char, no dot, nor parentheses)
• "aaaaaaaaaaaaaaaaaaaaaaaaaa" does not work (26 char, no dot, nor parentheses, only a char)
• "a" works (1 char)

To me, it is really a problem of long filenames. So, I will close the issue.

[astares]

@demarey:

please reopen the issue - it was verified and reproduced by three persons as you can see on the discord discussion on #seaside channel from the day we opened the bug.

[demarey]

I will take a look on Discord to see if I can reproduce