Bloc icon indicating copy to clipboard operation
Bloc copied to clipboard

Loading BlCore, BlTransformationExamples>>openInWindow:named:extent: fails

Open Ducasse opened this issue 5 years ago • 4 comments

openInWindow: anElement named: aTitleString extent: aPoint
	"Open a given element in a window of a provided extent and specified title"
	| aSpace |
	aSpace := BlSpace new
		extent: aPoint;
		title: aTitleString.
	
	aSpace root background: self spaceBackground.
	aSpace root addChild: anElement.

	aSpace root addEventHandler:
			(BlEventHandler
				on: BlDoubleClickEvent
				do: [ :evt | BlElementSelection on: evt target ]).
	
	aSpace show

Because BlElementSelection is unknown

Ducasse avatar Feb 08 '21 20:02 Ducasse

By a full string search in a text editor, I see that BlElementSelection belongs to category 'Bloc-DevTool-Core'.

tinchodias avatar Mar 09 '21 22:03 tinchodias

This openInWindow:named:extent: method is defined in TBlExample, which is not loaded by NewBloc.

tinchodias avatar Mar 09 '21 22:03 tinchodias

Now I found that still BlFlowLayoutCompositionExamples class>>#floatingCells and BlFlowLayoutCompositionSmokeTest class>>#floatingCells reference BlElementSelection.

So I reopen.

tinchodias avatar Mar 10 '21 16:03 tinchodias

I do not see any users of TBlExample. We will have to check what is Bloc-DevTool-Core.

Ducasse avatar Mar 25 '21 11:03 Ducasse

In v2.0.0, BlElementSelection is loaded. In the other hand, BlTransformationExamples was renamed as BlAnimationExamplesTest. Looking at this issue again made me improve the code.

tinchodias avatar Jul 09 '24 16:07 tinchodias

I close it, after https://github.com/pharo-graphics/Bloc/commit/2a16d0510fbb631eead4ffefdd64aa0bb19cbe9e

tinchodias avatar Jul 09 '24 16:07 tinchodias