pharo-graphics
Added new package with examples
Hello, I added some examples that @rvillemeur wrote for Bloc.
They are in a separate package called 'BookletGraphicsBloc' , this package needs 'Bloc' in its name to be recognized by the demo browser.
I also tagged some of those examples to the demo browser by adding the 'demo' pragma
Some examples are still not working and need to be reviewed before being added into a future pr, also some working examples have not been added and will come later
Enzo
I just added other examples on my repo but I thought the commit would automatically add to this pr and it doesn't seem to be the case, do I have to create another pr to add another commit to this pr ?
I just added other examples on my repo but I thought the commit would automatically add to this pr and it doesn't seem to be the case, do I have to create another pr to add another commit to this pr ?
@Enzo-Demeulenaere are you sure the additional examples are not included in this PR? If they are pushed to the same source branch, it should be included, I think.
So, the idea is to have this booklet code directly here in Bloc repo, but not loaded by the baseline? would the booklet indicate loading instructions to load manually this package from here? or the idea is that the baseline loads it, too.
The examples are quite diverse.
I'm sure the conflicting changes are not a big problem. But I am missing something: Is there a booklet that explains the code? @Enzo-Demeulenaere
For now let us just create contents and we can decide if we do one or two books. I'm working on Microdown to support a nice features for the book.
I began it with a unifying link, described here (What make most sense in my head, from low to high level) https://github.com/SquareBracketAssociates/Booklet-Graphics/blob/main/Chapters/pharogui.md
It has evolved since, with chapter more focused on Alexandrie/Bloc/Toplo, and other chapters that could be reused in other booklet, or pharo by example book
As Stephane say, we're adding contents for now, and we'll decide what is best latter. Renaud
10 sept. 2024, 11 h 50 de @.***:
@tinchodias> commented on this pull request.
In > src/BookletGraphicsBloc/AlexandrieCairoExperiment.class.st https://github.com/pharo-graphics/Bloc/pull/517#discussion_r1752235693> :
+The default line cap style is CAIRO_LINE_CAP_BUTT.+CAIRO_LINE_CAP_BUTT: start(stop) the line exactly at the start(end) point+CAIRO_LINE_CAP_ROUND: use a round ending, the center of the circle is the end point +CAIRO_LINE_CAP_SQUARE: use squared ending, the center of the square is the end point++The default line join style is CAIRO_LINE_JOIN_MITER.+CAIRO_LINE_JOIN_MITER: use a sharp (angled) corner, see cairo_set_miter_limit() +CAIRO_LINE_JOIN_ROUND: use a rounded join, the center of the circle is the joint point +CAIRO_LINE_JOIN_BEVEL: use a cut-off join, the join is cut off at half the line width from the joint point++Operators:+"+Class {+ #name : #AlexandrieCairoExperiment,+ #superclass : #Object,+ #category : #'BookletGraphicsBloc-Alexandrie'+}
Ah, yes, excellent booklet. What is your opinion, do the chapters have an unifying link so they deserve more to remain together? or are the chapters more unlinked so we split tham along the different projects?
— Reply to this email directly, > view it on GitHub https://github.com/pharo-graphics/Bloc/pull/517#discussion_r1752235693> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/ABXAC5525V3EQVIX7EY7P6DZV4IMNAVCNFSM6AAAAABIDJFCMWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJSHEZTGMZVGU> . You are receiving this because you were mentioned.> Message ID: > <pharo-graphics/Bloc/pull/517/review/2292933355> @> github> .> com>
I understand. But then, shouldn't this package, that is associated with the booklet, be in the same repo as the booklet?
For now I would add the example in the Bloc so that if API changes they change.
What about adding "cron" to CI in booklet repo, and I press on Watch on its repo to see
El jue, 12 sept 2024 a la(s) 5:18 a.m., StéphaneDucasse ( @.***) escribió:
For now I would add the example in the Bloc so that if API changes they change.
— Reply to this email directly, view it on GitHub https://github.com/pharo-graphics/Bloc/pull/517#issuecomment-2345575397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHHKMPHJU6WSDBIETWIXTZWFE6XAVCNFSM6AAAAABIDJFCMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGU3TKMZZG4 . You are receiving this because you were mentioned.Message ID: @.***>