Bloc icon indicating copy to clipboard operation
Bloc copied to clipboard

Can we merge fenster package into Bloc?

Open Ducasse opened this issue 2 years ago • 4 comments

There is no other user of these four classes

Ducasse avatar Aug 27 '22 07:08 Ducasse

The code is already in this repo, but it's not renamed, do you mean that?

https://github.com/pharo-graphics/Bloc/tree/master/src/Fenster https://github.com/pharo-graphics/Bloc/tree/master/src/Fenster-Tests

tinchodias avatar Aug 27 '22 14:08 tinchodias

Ok I did not notice that it was in the same repo. Now we could rename it bloc-something.

Ducasse avatar Aug 28 '22 13:08 Ducasse

Strange to read the class names due to the project name and mixed language: because "Fenster" is "Window" in german. So "FensterPosition" is basically "WindowPosition" ...

astares avatar Aug 28 '22 16:08 astares

I think we should rename them to Window so it is clear. Thanks for the hint @astares

tesonep avatar Aug 29 '22 08:08 tesonep

I renamed to Bloc-Display, I hope you agree! Using the word window was weird as it's not used in Bloc (a BlSpace is a window).

tinchodias avatar Oct 18 '22 22:10 tinchodias

It could be also Bloc-ScaleFactor, or Bloc-Space-ScaleFactor, because these classes are about the scale factor, that makes that in retina (HiDPI), 200@200 size means 400@400.

tinchodias avatar Oct 18 '22 23:10 tinchodias

Ok perfect. This is good to remove this dependency.

Ducasse avatar Oct 19 '22 06:10 Ducasse