Use KMKeyCombination instead of BlKeyCombination?

[tinchodias]

My impression is that they represent the same concepts and are built in a similar way.

But it's not only changing one class by another, of course. This is how 'Bloc-Events-KeyBinding' looks in Calypso:

[plantec]

and you can add the classes BlKeyCombinationVisitor, BlKeyCombinationConverterCNF, BlKeyCombinationConverterDNF to compute DNF and CNF. It seems to me that it is over-engineered in the context of key binding. At least these classes should not be in Bloc but in a separate package. I would be more in favor of re-using KM

[tinchodias]

@plantec

I browsed and debugged a bit the Keymapping package (KM). I think it covers the functionality of DNF and CNF logical structures to express key combinations. Unless I missed something.

But also, KM seems to have much better support to:

• define alternatives for each OS platform
• print (convert to string) the current keybinding, which is very useful to show it in menus

My impression was that it's very possible to switch to KM.

BUT, this is kind of the first time I dig into this package so I may be missing something.

[tinchodias]

@plantec do you have any new opinion about this idea?

[jecisc]

Hi,

I found this issue because I wanted to open one to say the same thing and I found this one!

I personally think that we should indeed is KM and not redo a keymapping system. Duplicating this kind of system will only lead to more bugs in the future. If KM misses some things we should improve it IMO.

I don't know how hard it would be to migrate and how this would impact the code of Bloc users, but migrating to KM seems to be the right move to me.

[plantec]

ok for switching to KM but no time now to do it in Toplo

[tinchodias]

@jecisc thanks for looking at this issue. Could you show us some example of what should be changed in Toplo in the case of migrating to KM?