admiral icon indicating copy to clipboard operation
admiral copied to clipboard

Closes #2897 ADAB Vignette

Open Kcdahn opened this issue 1 month ago • 1 comments

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • [ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • [ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • [ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • [ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • [ ] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
  • [ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • [ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • [ ] Address any updates needed for vignettes and/or templates
  • [ ] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
  • [ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • [ ] Address or fix all lintr warnings and errors - lintr::lint_package()
  • [ ] Run R CMD check locally and address all errors and warnings - devtools::check()
  • [ ] Link the issue in the Development Section on the right hand side.
  • [ ] Address all merge conflicts and resolve appropriately
  • [ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Kcdahn avatar Nov 12 '25 23:11 Kcdahn

Code Coverage

Package Line Rate Health
admiral 100%
Summary 100% (5714 / 5722)

github-actions[bot] avatar Nov 12 '25 23:11 github-actions[bot]

Can you add some printouts of data at various steps along the way using dataset_vignette()?

jeffreyad avatar Dec 10 '25 21:12 jeffreyad

All. I have also been receiving comments in the main ADAB branch (2805_add_template_for_adab). There have been some code and comment updates there and maybe more coming. When the main ADAB is near final, I was thinking of then re-adding all the code one last time here then, rather then trying to keep them aligned manually (I am adding some however anyway).

Kcdahn avatar Dec 11 '25 17:12 Kcdahn

All. I have also been receiving comments in the main ADAB branch (2805_add_template_for_adab). There have been some code and comment updates there and maybe more coming. When the main ADAB is near final, I was thinking of then re-adding all the code one last time here then, rather then trying to keep them aligned manually (I am adding some however anyway).

yes agree - please finish template and let's merge in as final and then move onto the vignette.

we wanted to label as experimental in 1.4 release and see if CDISC ADaM group would review once release and others in community.

bms63 avatar Dec 11 '25 18:12 bms63