riskassessment icon indicating copy to clipboard operation
riskassessment copied to clipboard

Need other visual indicators for Pkg Decision on Database Tab

Open AARON-CLARK opened this issue 2 years ago • 5 comments

@Jeff-Thompson12 mentioned it may be nice to have other visual indicators besides colors, like an exclamation point or a thumbs up or emoji faces next to the each decision on the database tab.

Originally posted by @AARON-CLARK in https://github.com/pharmaR/riskassessment/issues/325#issuecomment-1372475500

AARON-CLARK avatar Jan 11 '23 18:01 AARON-CLARK

Waiting for PR #459 Custom Decision Categories to get merged.

Robert-Krajcik avatar Mar 23 '23 17:03 Robert-Krajcik

Hey @AARON-CLARK I'm thinking this might be better incorporated into PR #459 Custom Decision Categories. I know that PR is HUGE already but I think this ties into it. Your thoughts?

Robert-Krajcik avatar Mar 24 '23 03:03 Robert-Krajcik

@Robert-Krajcik, you are right. But I think we're trying to get that PR pushed through, so we can still follow up on this issue after 459 is merged.

@Jeff-Thompson12, what do you think? Do you think we could give users the option to specify an icon name in the config file for each decision category, if desired? It may add unnecessary complexity to the config file. Perhaps it's better if integrated at the same time #465 where we'll allow custom coloring to decision categories.

AARON-CLARK avatar Mar 24 '23 11:03 AARON-CLARK

I think we are firmly at the point where any enhancements to #459 need to be follow up PRs.

Jeff-Thompson12 avatar Mar 24 '23 12:03 Jeff-Thompson12

OK, but I think this should not get developed independently of #459 @Jeff-Thompson12 and @AARON-CLARK and probably best to wait until this one gets merged

Robert-Krajcik avatar Mar 24 '23 13:03 Robert-Krajcik

I'm going to close this for now since the decision names and colors are pretty informative as it is.

aclark02-arcus avatar Jul 03 '24 15:07 aclark02-arcus