phive icon indicating copy to clipboard operation
phive copied to clipboard

Published 20 hours ago • verified publisher icon phar-io

Go explicit in PharRegistry

Open szepeviktor opened this issue 1 year ago • 6 comments

From https://github.com/phar-io/phive/commit/e863dce2a973c2c54f986a04cff689109acccc15

szepeviktor avatar Aug 02 '22 08:08 szepeviktor

💡 There is no CS rule to spot unused imports: use DOMNode;

szepeviktor avatar Aug 02 '22 08:08 szepeviktor

bulb There is no CS rule to spot unused imports: use DOMNode;

We probably should add that ;)

theseer avatar Aug 02 '22 08:08 theseer

https://github.com/phar-io/phive/blob/749915d231c9f325261fa23f7372ddf62771a920/.php-cs-fixer.dist.php#L171 ?

szepeviktor avatar Aug 02 '22 08:08 szepeviktor

I see! That workflow does not run on PR-s. https://github.com/phar-io/phive/blob/749915d231c9f325261fa23f7372ddf62771a920/.github/workflows/ci.yml#L3

szepeviktor avatar Aug 02 '22 08:08 szepeviktor

I see! That workflow does not run on PR-s.

https://github.com/phar-io/phive/blob/749915d231c9f325261fa23f7372ddf62771a920/.github/workflows/ci.yml#L3

Feel free to add that in a PR :) I'm rather busy today, sorry..

theseer avatar Aug 02 '22 11:08 theseer

@theseer Friendly ping 🏓

szepeviktor avatar Apr 05 '24 09:04 szepeviktor