manifest icon indicating copy to clipboard operation
manifest copied to clipboard
verified publisher icon phar-io

New Feature: a `PharIo\Manifest\ManifestValidator` will be greatly appreciated

Open llaville opened this issue 2 years ago • 9 comments

Hello,

As title suggest new class, it will be greatly appreciated to have ability to validate a manifest after creation by API or loading from external source !

llaville avatar Jun 10 '23 13:06 llaville

Any news about this new feature ?

llaville avatar Oct 11 '23 04:10 llaville

I still like the idea but I'm not convinced it belongs into this project but should be a separate library. What do you think?

theseer avatar Oct 12 '23 20:10 theseer

Sorry but I don't think it should be separated from this project !

It's same thing, if you said :

  • we should separate PHP DomDocument validation against schema from dom extension : --> DOMDocument::schemaValidate
  • we should separate Composer validation against schema from its project : --> https://github.com/composer/composer/blob/2.6.5/src/Composer/Command/ValidateCommand.php --> https://github.com/composer/composer/blob/2.6.5/src/Composer/Util/ConfigValidator.php#L53 --> https://github.com/composer/composer/blob/2.6.5/res/composer-schema.json
  • or we should separate BOX validation against schema from its project : --> https://github.com/box-project/box/blob/4.4.0/src/Json/Json.php#L91 --> https://github.com/box-project/box/blob/4.4.0/res/schema.json

I stop here list of examples that provided embedded validator features !

I know it's more work for you, but it'll help to improve QA of your project.

llaville avatar Oct 14 '23 07:10 llaville

okay, point taken. I'll probably implement that over the next week when I'm traveling. Let's see how that works out :)

theseer avatar Oct 20 '23 12:10 theseer

Any news about status of this new feature ?

llaville avatar Mar 11 '24 05:03 llaville

I hope to have some time working on these soon.

theseer avatar Mar 21 '24 09:03 theseer

You have probably forgotten or too busy to work on this request. Should I consider to close this report ?

llaville avatar Jun 02 '25 04:06 llaville

Closing this request. If you think finally this feature is a good point to your project, you know what to do.

llaville avatar Jun 10 '25 03:06 llaville

Sorry for the radio-silence. You're perfectly right I'm way busy and my open source work is suffering greatly :-( I'm really grateful for your idea and suggested implementation. I promise to have a look again when I have some more time.

I'll reopen this, so it doesn't fully drop of the radar.

theseer avatar Jun 10 '25 07:06 theseer