deepwalk icon indicating copy to clipboard operation
deepwalk copied to clipboard

Why do we need vocabulary_counts in skipgram.py?

Open phucdoitoan opened this issue 4 years ago • 1 comments

Hi, I try to figure out the role of vocabulary_counts in skipgram.py, but it seems that the variable self.vocabulary_counts does not have any effect on the codes. In the Word2Vec implementation https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/word2vec.py there is no use for vocabulary_counts neither.

Is it just a variable of an older version that is not necessary now?

phucdoitoan avatar Feb 29 '20 04:02 phucdoitoan

Yeah you are right! The skipgram.py implementation is based on a rather old version of Gensim word2vec; it is not necessary anymore. Would you like to clean this up? Happy to help with reviewing this. Thank you!

GTmac avatar Mar 08 '20 16:03 GTmac