eslint-plugin-editorconfig icon indicating copy to clipboard operation
eslint-plugin-editorconfig copied to clipboard

`unset` values

Open piranna opened this issue 2 years ago • 2 comments

According to the spec, if any value is the unset string, it should disable the rule and accept editor defaults, but I see no references in the source code. We should check the values before hand and disable the rules if possible, or at least set them to undefined so eslint defaults are being used instead. Not sure if this can be done in a preprocessing step, or would need to be done in a rule-by-rule basis, specially when a rule makes use of several editorconfig definitions.

piranna avatar Jul 01 '23 11:07 piranna

https://github.com/editorconfig/editorconfig-core-js/issues/123

piranna avatar Jul 02 '23 07:07 piranna

https://github.com/editorconfig/editorconfig-core-js/issues/123#issuecomment-1616807695

Published version 2.0.0 of editorconfig-core-js just to provide upstream the fix needed by this, so we don't need to do it ourselves.

piranna avatar Jul 02 '23 22:07 piranna