kupo icon indicating copy to clipboard operation
kupo copied to clipboard

Add insights checker

Open barryvdh opened this issue 7 years ago • 11 comments

This adds https://github.com/dsentker/phpinsights by @dsentker and checks the Google Pagespeed Insights API for mobile and desktop, when the key is set.

It also shows the screenshots from mobile/desktop and the speed/usability scores.

barryvdh avatar Mar 27 '17 19:03 barryvdh

Example:

screen shot 2017-03-27 at 22 00 09

barryvdh avatar Mar 27 '17 20:03 barryvdh

i think better to use from client side directly, not to overload server

hbakhtiyor avatar Apr 03 '17 14:04 hbakhtiyor

@hbakhtiyor What do you mean, calling the Insights API? That shouldn't be very intensive..

@phanan What do you think?

barryvdh avatar Apr 07 '17 07:04 barryvdh

@barryvdh yeah, calling directly to Insights API

hbakhtiyor avatar Apr 07 '17 08:04 hbakhtiyor

Calling the API shouldn't be a problem.

phanan avatar Apr 07 '17 09:04 phanan

No indeed.

But I meant, what do you think of the rest of the PR?

barryvdh avatar Apr 07 '17 09:04 barryvdh

Oh, sorry. Actually IMO breaking the insight results into individual items is a bit too much. I'd prefer using the score for the headline and the rest for expanded details.

phanan avatar Apr 07 '17 09:04 phanan

Also, why do we have two Levels::WARNING again?

phanan avatar Apr 07 '17 09:04 phanan

And sorry for not following up the repo very closely these days, I currently have lots of personal stuff to deal with :(

phanan avatar Apr 07 '17 09:04 phanan

Ah right, one should be ERROR indeed.

We could be to just show the once that are failing, not all the green ones.

Or perhaps add a different options to check using kupo rules, but also a check for Insights. The interface is very nice for it imho :)

barryvdh avatar Apr 07 '17 09:04 barryvdh

And no rush, take your time :)

barryvdh avatar Apr 07 '17 09:04 barryvdh