swapi icon indicating copy to clipboard operation
swapi copied to clipboard

Person: key species: String instead of [String]

Open AndreaMiotto opened this issue 9 years ago • 4 comments

Hi @phalt . Awesome job with this API, but I don't understand your choice for species' key in the person type. Why is it an array of String?? I've checked all the person records, and all the records have just one specie. And it's quite normale, I mean a person should have just one specie, how is it possibile to belong to two species?

So the specie's key shouldn't be just a single String like for planets?

I'm telling you because to fetch the species' name for the people it costs one more function than the planets name fetching.

Regards, Andrea Miotto

AndreaMiotto avatar Oct 25 '16 10:10 AndreaMiotto

What if a character does have more than one species? 😉

phalt avatar Oct 25 '16 10:10 phalt

How can it be possible? 😁

AndreaMiotto avatar Oct 25 '16 13:10 AndreaMiotto

It's a science fiction show!

phalt avatar Oct 25 '16 14:10 phalt

Darth Vader is actually half man/half machine ... it's a data problem not a type problem ...

nrapopor avatar Mar 27 '17 03:03 nrapopor