swapi icon indicating copy to clipboard operation
swapi copied to clipboard

Brief Character Descriptions

Open tbone849 opened this issue 9 years ago • 7 comments

It would be nice if each character had a sentence or two description. It would really tie the data together nicely. Knowing their physical characteristics just doesn't seem enough in this case. I am only proposing this for the characters.

Example:

name: 'Anakin Skywalker', bio: 'Anakin Skywalker was a Force-sensitive human male who served the Galactic Republic as a Jedi Knight, and later the Galactic Empire as the Sith Lord Darth Vader.'

(Bio was one-liner from wookiepedia)

tbone849 avatar Feb 04 '16 13:02 tbone849

What if this just became

name: 'Anakin Skywalker',
description: 'Anakin Skywalker was a Force-sensitive human male who served the Galactic Republic as a Jedi Knight, and later the Galactic Empire as the Sith Lord Darth Vader.'

This way, you can also add it to the other items:

name: 'Aleraan'
description: 'From space, the planet of Alderaan, located in the star system of the same name, appeared as a blue-green orb envelopped in a white web of clouds. Its surface had vast bodies of water and was covered in snow-capped mountains, with patches of green grassy hills. Alderaan was known to the galaxy as "the planet of beauty." Famous natural landmarks of Alderaan included the Cloudshape Falls and the Isatabith rain forest.'
name: 'TIE Bomber',
description: 'The TIE bomber was a bombing variant of the TIE line used by the Galactic Empire, and was their main source of anti-emplacement air-support.'

walterg2 avatar Aug 08 '16 00:08 walterg2

Originally I was just thinking characters, but looking back on this, what you proposed would be awesome!

tbone849 avatar Aug 08 '16 01:08 tbone849

Is this going to happen guys?

euanwho avatar Aug 15 '16 20:08 euanwho

@euanwho we're accepting pull requests :)

phalt avatar Aug 16 '16 09:08 phalt

Feel free to assign this to me!

euanwho avatar Aug 16 '16 14:08 euanwho

@euanwho it's all yours!

phalt avatar Aug 16 '16 15:08 phalt

I've submitted a pull request, but there are a couple of errors that I don't understand. Maybe someone could help

euanwho avatar Aug 16 '16 17:08 euanwho