swapi icon indicating copy to clipboard operation
swapi copied to clipboard
verified publisher icon phalt

Adding new films

Open rohittm opened this issue 8 years ago • 3 comments

I guess, new films (Rogue One, The Last Jedi, and Solo), Needs to be added to the list 😅

rohittm avatar Apr 24 '18 20:04 rohittm

As I've been saying for a few years now - happy to accept PRs with this data 😆

But I will make one judgement - SWAPI will only have the main series films (numbered movies), not anthology films.

phalt avatar May 01 '18 10:05 phalt

@phalt Is the fixtures folder where we would create a pull request with data? I'm noticing that the live site has data for 7 but the source code here doesn't, wondering what your db structure is.

ajwallacemusic avatar Oct 17 '18 19:10 ajwallacemusic

This is great, I'll be sure to get contributing asap. Well done Phalt, you've made my day.

Is all the data held in this static json? https://github.com/phalt/swapi/tree/master/resources/fixtures

Willshaw avatar Nov 20 '18 09:11 Willshaw