cphalcon icon indicating copy to clipboard operation
cphalcon copied to clipboard

The ext/json is always available since PHP 8.0

Open petk opened this issue 2 years ago • 2 comments

The HAVE_JSON symbol is removed with PHP 8.4.0+.

Hello!

  • Type: bug fix
  • Link to issue: https://github.com/phalcon/cphalcon/issues/16523

In raising this pull request, I confirm the following:

  • [x] I have read and understood the Contributing Guidelines
  • [x] I have checked that another pull request for this purpose does not exist
  • [ ] I wrote some tests for this PR
  • [ ] I have updated the relevant CHANGELOG
  • [ ] I have created a PR for the documentation about this change

Small description of change:

The HAVE_JSON symbol is removed with PHP 8.4.0+ in php_config.h. Perhaps fixing this can be done something like in the pull request, since the PHP 8.0 is the minimum required version for Phalcon since Phalcon 5.6.

Otherwise, PR needs to be adjusted further.

Thanks

petk avatar Feb 02 '24 15:02 petk

@Jeckerson to review

@petk Please target 5.0.x branch. We don't commit directly to master.

Thank you!

niden avatar Feb 03 '24 02:02 niden

This is from Zephir side, will try check soon.

Jeckerson avatar Feb 07 '24 22:02 Jeckerson