MyExtensions icon indicating copy to clipboard operation
MyExtensions copied to clipboard

Published 20 hours ago • verified publisher icon phaistonian

Google Sync support

Open devnull69 opened this issue 10 years ago • 11 comments

Hi there

is it planned to change the extension to store the options and extension information (and everything else currently located in localStorage) in Google Sync? If not, I could implement it in my fork and send a pull request afterwards ...

Regards Thomas

devnull69 avatar Apr 09 '14 06:04 devnull69

Hey Thomas.

I was planning to implement some sort of syncing using BSync (used in Chrome Notepad extension), but unfortunately spare time is not something easy to find any more.

That said, It'd be great if you could provide Google Sync functionality and I will be more than happy to merge it.

phaistonian avatar Apr 09 '14 06:04 phaistonian

Would you prefer to let the user choose between localStorage and Google sync or should Google sync be the preferred way with localStorage as a fallback?

devnull69 avatar Apr 09 '14 08:04 devnull69

Both will do do.

In fact, utilising both methods (transparently) would probably be the way to go.

Again, it's up to you :-)

phaistonian avatar Apr 09 '14 08:04 phaistonian

Again I lost my list of apps :-(. I might create a pull request having the extension use chrome.storage.sync instead of localStorage, which seems to get destroyed pretty frequently

kzahel avatar Sep 04 '14 11:09 kzahel

@kzahel: Wow, I had no idea such an API was implemented (I haven been away from extensions for quite some time).

Yes, that 'd be ideal.

Please create this pull request, I am sure more people will be benefited from such a change.

phaistonian avatar Sep 04 '14 11:09 phaistonian

https://github.com/kzahel/MyExtensions/commit/f687e0094dbc881b9933fe30b073362c0244c840 I tried real quick to see if doing the braindead thing would work, but it's not working very well because of what appears to be race conditions when saving to the "data" key asynchronously. So it's going to take a little refactoring ... :-(

kzahel avatar Sep 04 '14 12:09 kzahel

https://github.com/kzahel/MyExtensions/commit/877630044e0adad091d584e878ac4544e097dd14

Did a little more work, it's going to take a lot of testing before I feel it's stable at all though. I'm not sure if it's broken other things yet.

I think it would make sense to only store the list of extensions in the chrome.storage.sync and the other data (ratings, etc) in the chrome.storage.local

kzahel avatar Sep 11 '14 09:09 kzahel

True, that would make perfect sense.

Thank you for your efforts.

phaistonian avatar Sep 11 '14 09:09 phaistonian

Hey @kzahel.

Any progress with this long-standing issue?

phaistonian avatar May 20 '16 08:05 phaistonian

Wow, I had no idea such an API was implemented (I haven been away from extensions for quite some time).

Yes, that 'd be ideal.

Please create this pull request, I am sure more people will be benefited from such a change.

Aplokjoy avatar Dec 27 '19 17:12 Aplokjoy

#29

Aplokjoy avatar Dec 31 '19 07:12 Aplokjoy