Philip Hackstock
Philip Hackstock
> Parsing a DataStructureDefinition for large projects is already taking quite some time, so adding yet another pydantic-validator (executed every time) might not be the smartest move. Without having run...
Puh, that's a tricky one, option 1 is certainly more efficient but option 2 is more explicit and covers more complex filters. What kind of filter operations would you imagine...
@danielhuppmann, good point, I'm definitely not sure for the moment if we even want this feature.
Very nice, I think this should become a property of the `RegionAggregationMapping` class. This way, you could run: ```python dsd = nomenclature.DataStructureDefinition("definitions/") rp = nomenclature.RegionProcessor.from_directory("mappings/", dsd) model="Some Model" rp.mappings[model].common_region_country_mapping ```...
It's a good idea for sure and one that we should definitely implement in the future. For now, though I'd see it as a low priority item since it would...
If only someone wrote something like that :laughing:
Sure, it's going to be a short issue to tackle. The longest part is probably going to be to adjust the tests. Potentially, we should align the entire error reporting....
> On the other hand, changing path to "the path except definitions" would require changing all workflow-repositories... True, it is a breaking change in the API of `DataStructureDefinition` so we...
I find the name `validate-scenarios` a little bit misleading. In my mind I thought the function validates the values in the scenario column and not an entire data frame. I'd...
Ah ok thanks for the clarification. To avoid further misunderstandings, by "added as we move forward" you mean that #419, will be merged and then follow-up RPs will implement 2...