arcanist icon indicating copy to clipboard operation
arcanist copied to clipboard

Updates for PHP 8.4 compatibility

Open ReadyCloudSuite opened this issue 1 year ago • 6 comments

  • Fixed FutureProxy::__construct(): Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.
  • Fixed Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.
  • Fixed Passing null to parameter #1 ($status) of type string|int is deprecated.

ReadyCloudSuite avatar Dec 23 '24 11:12 ReadyCloudSuite

Thanks, I applied this patch and arcanist is working again. I also had to turn off deprecation warnings to be able to parse the JSON output.

diff --git a/bin/arc b/bin/arc
index 51528ca0..696f8191 100755
--- a/bin/arc
+++ b/bin/arc
@@ -1,5 +1,6 @@
 #!/usr/bin/env php
 <?php
+error_reporting(E_ALL ^ E_DEPRECATED);
 
 if (function_exists('pcntl_async_signals')) {
   pcntl_async_signals(true);

gregtatum avatar Feb 18 '25 13:02 gregtatum

Please can somebody merge this to master.

semsudin avatar Mar 03 '25 09:03 semsudin

Please can somebody merge this to master.

dushaoshuai avatar May 31 '25 15:05 dushaoshuai

Please can somebody merge this to master.

ez4bk avatar Jul 08 '25 07:07 ez4bk

@semsudin @dushaoshuai @ez4bk Phabricator is officially dead. You guys should try https://github.com/phorgeit/arcanist instead.

cheack avatar Jul 08 '25 19:07 cheack

Lol, I downgraded php as a short term mitigation. 8.4 is officially broken in this repo.

brew install [email protected]
brew link --overwrite --force [email protected]
php --version
PHP 8.3.25 (cli) (built: Aug 26 2025 15:05:30) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.25, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.25, Copyright (c), by Zend Technologies

8.3 is still supported... for now. https://www.php.net/supported-versions.php

gregtatum avatar Sep 25 '25 16:09 gregtatum