irida icon indicating copy to clipboard operation
irida copied to clipboard

Missing ILLUMINAMISEQ constant prevents viewing NCBI Export page

Open apetkau opened this issue 2 years ago • 1 comments

Describe the bug

On one of our IRIDA instances, when I go to Admin > NCBI Exports, the page fails to load and the following line is found in the log file.

No enum constant ca.corefacility.bioinformatics.irida.model.export.NcbiInstrumentModel.ILLUMINAMISEQ

I believe this is caused by the change of the constant from ILLUMINAMISEQ to ILLUMINA_MI_SEQ as found here:

https://github.com/phac-nml/irida/blob/62b88f2214e8c53547bc6968b3ff5a3fd3be25ba/src/main/java/ca/corefacility/bioinformatics/irida/model/export/NcbiInstrumentModel.java#L37

If an IRIDA instance previously had ILLUMINAMISEQ stored in the database, this will no longer work.

Steps to reproduce the problem

What were you doing when you encountered the problem?

  1. Log into an IRIDA instance where previously an NCBI Export was performed prior to 22.09 and the Instrument was a MiSeq.
  2. Load up the Admin > NCBI Exports page.
  3. The page will fail to load and you will see the above message in the logs.

Expected behaviour

I expected the page to succeed in loading.

Additional context

None.

apetkau avatar Nov 17 '22 18:11 apetkau

Looks like these were renamed here without a migration.

https://github.com/phac-nml/irida/pull/1324/files#diff-5d152508efbb40d0fa7ce82627c2a24635689d9d4b2662005e0533f2a46c649f

ericenns avatar Nov 17 '22 19:11 ericenns

This was fixed in #1436

joshsadam avatar Jan 13 '23 16:01 joshsadam