hop.nvim icon indicating copy to clipboard operation
hop.nvim copied to clipboard

Published 20 hours ago • verified publisher icon phaazon

Fix regression of #267 (Error: col val outside range)

Open spamwax opened this issue 3 years ago • 3 comments

Fix regression of phaazon/hop.nvim#267 caused by pull#315

  • opts.col passed to nvim_buf_set_extmark() expects it to be 0-indexed. phaazon/hop.nvim#315 causes an empty line to retun 1 for cursor's column. This PR checks if the current line is empty and sets the correct column in 'contexts' that'll be used later in nvim_buf_set_extmark() in set_unmatched_lines()

spamwax avatar Nov 10 '22 02:11 spamwax

Is something preventing this PR from being merged?

phgz avatar Dec 28 '22 03:12 phgz

Been waiting for this for a while. I'm pinned to a previous (and pretty old) commit so that I can continue to use this plugin. I'm excited for this issue to be resolved so I can update.

brettmitchelldev avatar Jan 11 '23 10:01 brettmitchelldev

Until the maintainer finds time to maintain the PRs in this repo again, I'll try to get maintenance / somehow critical stuff into this fork: https://github.com/mistweaverco/hop.nvim

I cherry picked your commit into the master branch of the fork already :) Thanks for your effort!

gorillamoe avatar Jun 09 '23 17:06 gorillamoe