hop.nvim icon indicating copy to clipboard operation
hop.nvim copied to clipboard

Published 20 hours ago • verified publisher icon phaazon

Fix some bugs

Open aznhe21 opened this issue 2 years ago • 7 comments

This PR fixes these bugs:

  1. Running :HopVerticalAC when the cursor is on an empty line will print "col value outside range".
  2. Running :HopVerticalMW when there is a floating window will print Invalid buffer id: N.
  3. A potential issue that could cause "Not allowed to change text or change window".

aznhe21 avatar Oct 12 '22 14:10 aznhe21

I had this problem with HopLineStartAC in my environment. This PR fixed it! Thanks!

  1. Running :HopVerticalAC when the cursor is on an empty line will print "col value outside range".

uplus avatar Oct 24 '22 03:10 uplus

Can you document your changes? The plugin starts to become a mess with all the changes in the PRs trying to fix that problem, I will probably refactor all of that in a couple of days and I need to understand exactly what does what.

hadronized avatar Oct 30 '22 15:10 hadronized

Sorry for the late reply. I have added comments about the changes. Please check it out.

aznhe21 avatar Nov 08 '22 06:11 aznhe21

I'm using this branch and it seems to fix #335 👍🏾

FelipeLema avatar Nov 10 '22 01:11 FelipeLema

Any progress on this?

chaudry-786 avatar Dec 07 '22 12:12 chaudry-786

I'm waiting (for over a month!) for a review. @phaazon Please confirm and merge.

aznhe21 avatar Dec 08 '22 14:12 aznhe21

@phaazon any chance this could get reviewed and merged?

snaveevans avatar Apr 17 '23 20:04 snaveevans