Sharp.Xmpp icon indicating copy to clipboard operation
Sharp.Xmpp copied to clipboard

XmppCore.IqRequest bug

Open cimframe opened this issue 8 years ago • 0 comments

In testing vCard avatar updates, a bug was detected in the request response parsing.

The old code:

if (request.To.Domain == Jid.Domain && (request.To.Node == null || request.To.Node == "") && (ping != null && ping.NamespaceURI == "urn:xmpp:ping"))

was replaced with:

if (request.To != null && request.To.Domain == Jid.Domain && string.IsNullOrEmpty (request.To.Node) && (ping != null && ping.NamespaceURI == "urn:xmpp:ping"))

The fact that avatars are sent out to a PEP subscription, there is no TO! That fixes that!

cimframe avatar Mar 12 '17 20:03 cimframe