node-websocket-client icon indicating copy to clipboard operation
node-websocket-client copied to clipboard

Fix the lib for v0.5 and v0.6 of nodejs. It's also backward compatible with v0.4

Open alaingilbert opened this issue 12 years ago • 2 comments

Fix the lib for v0.5 and v0.6 of nodejs. It's also backward compatible with v0.4

alaingilbert avatar Nov 16 '11 05:11 alaingilbert

hey alain,

thanks for the fix. I merged it with mine, and added try/catches,

would your fix still work if it's done that way?

checkout https://github.com/pgriess/node-websocket-client/pull/21/files

Thanks.

quangv avatar Nov 18 '11 13:11 quangv

No. Because in node v0.4.x http.request exists, but you need to do http.createClientto make it work. (tested with node v0.4.12 and v0.6.1)

alaingilbert avatar Nov 18 '11 19:11 alaingilbert