Patrick Grawehr
Patrick Grawehr
@angularsen No worries, take your time. Good coders are always busy ;-)
@angularsen There seems to be a weird problem with the use of `UnitsNetJsonConverter` that now throws a MissingMethodException I don't fully understand. Possibly due to a mix of using the...
@angularsen The entire PR is intended to go to v5 only.
@lipchev Yea, it's still strange that the test fails, as it only uses old implementations (or maybe not?) I forgot about this, but I'll have a look when I find...
@angularsen You write above that you want the compatibility tests still to pass, but given v5 doesn't even have the `UnitsNetJsonConverter`, I agree that the tests should just be removed....
@angularsen Hi! I've lost track of this one a bit, but how shall we go on? It would be good if we could finally come to a conclusion (and get...
No, I don't think this should be wontfix. A PR for this is pending (but apparently waiting for other stuff to get done as well)
@angularsen @tmilnthorp Are there any plans when 4.X will be branched out so that some of the pending breaking changes could be implemented for 5.0? The number formatting is unfortunately...
I'm quite busy at the moment, but I'll try to adapt #795 for that branch. I also need to check whether there's any leftovers from #788 (such as formatting obtions...
Two points: First, IIRC default ToString() does not emit number separators, so probably the default Length.ToString() shouldn't, either. That would solve the basic round-trip problem. Round-tripping is only a problem...