pgfplots icon indicating copy to clipboard operation
pgfplots copied to clipboard

Published 20 hours ago • verified publisher icon pgf-tikz

Duplicate code lines?

Open muzimuzhi opened this issue 5 years ago • 3 comments

To answer this TeX-SX question, in which the OP wants to draw tick lines as circle marks instead of short lines, I read a bit of source code related to ticks, and find two adjacent same lines https://github.com/pgf-tikz/pgfplots/blob/d85789248e5c0352ea0ec9349914e5ae87c8a0b1/tex/generic/pgfplots/pgfplotsticks.code.tex#L1469-L1470

muzimuzhi avatar Jul 10 '20 07:07 muzimuzhi

@muzimuzhi, when you are sure that the duplicate line can safely be removed, add a PR. (Christian will not invest time in the near future.)

(I'll ping you on some other issues as well, which you/we already started. Just ignore them, if you (still) insist/think that Christians approval is needed.)

Mo-Gul avatar Jan 04 '22 20:01 Mo-Gul

@Mo-Gul Now that support for GitHub Actions has been merged I'll soon try to get the testsuite running. Then we can confidently merge fixes without further approval.

hmenke avatar Jan 04 '22 21:01 hmenke

@hmenke, great.

Nonetheless I would like to ask for approval when I think I have made commits which you might dislike, as was the case in history with changes in "spacing" (see 2 of the 4 current PRs from me :)) So that we are on the same page and have an agreed procedure: Shall I add you as a reviewer in these cases?

Mo-Gul avatar Jan 05 '22 08:01 Mo-Gul