pgrx icon indicating copy to clipboard operation
pgrx copied to clipboard

Generate bindings for functions provided by the `cshim` using bindgen.

Open thomcc opened this issue 2 years ago • 4 comments

Depends on #813, so ignore the 3 patches that come from that.

Need to think a little bit about the approach here, since this is kinda hacky. It might be better done after #798, but I'm not 100% sure yet.

thomcc avatar Oct 24 '22 19:10 thomcc

Not sure why it passes locally but it seems that this needs to have the path to the cshim added to the include when building the cshim (this is more a note for future me than anybody else). That's not hard, I'll do that in a bit (this will need rebasing anyway after #813 lands).

thomcc avatar Oct 24 '22 19:10 thomcc

I'm going to say we can't actually do this one until we drop pg10 support, due to the bool differences.

thomcc avatar Oct 26 '22 19:10 thomcc

Blocked on:

  • https://github.com/tcdi/pgx/pull/830

workingjubilee avatar Oct 31 '22 21:10 workingjubilee

@workingjubilee @thomcc #830 has been merged into develop.

BradyBonnette avatar Nov 01 '22 15:11 BradyBonnette