pgrx icon indicating copy to clipboard operation
pgrx copied to clipboard

Published 20 hours ago • verified publisher icon pgcentralfoundation

Adding post_parse_analyze hook

Open hamin opened this issue 2 years ago • 4 comments

hamin avatar Apr 15 '22 18:04 hamin

I replied on discord with this:

I’m on yet another road trip today but it looks like you hand-edited the bindings files. Instead, update the includes/*.h files to pull in the Postgres header with the new symbols

The bindings .rs files we keep in git are to appease docs.rs builds and are not used at all during normal compilation processes. Which is why you’re getting the undefined symbol errors

eeeebbbbrrrr avatar Apr 18 '22 15:04 eeeebbbbrrrr

(This PR seems abandoned, closing)

Hoverbear avatar Jun 28 '22 20:06 Hoverbear

@Hoverbear sorry been busy with work and have vacation coming up tomorrow for a few weeks. I think I can get back to this on mid july. What's the protocol? Open a. new PR or reopen this PR when i'm ready?

Thanks in advance!

hamin avatar Jun 28 '22 21:06 hamin

@hamin It's no problem! :) We'd still be happy to merge when you got time to make it work via the headers as discussed. You can always ping us if you want some help.

I really hope you enjoy your vacation and get to do everything you desire on it! If you don't get back to this until after, it's ok. Relaxing comes first on vacation.

Hoverbear avatar Jun 29 '22 00:06 Hoverbear

An updated variant of this PR landed in https://github.com/tcdi/pgx/pull/800. Thank you!

workingjubilee avatar Nov 02 '22 23:11 workingjubilee

@workingjubilee No worries! Was thinking about getting back on this work last week! But glad its in so I can pick up my pet project again :)

hamin avatar Nov 03 '22 16:11 hamin