pgrx icon indicating copy to clipboard operation
pgrx copied to clipboard

Completely dismantle Actions-based tests except for combinatorics

Open workingjubilee opened this issue 1 year ago • 3 comments

There are sets of tests that we have that should just be entered by a single command, like the tests for the individual "example extensions". They make fixing problems with them extremely slow because like fuck is anyone going to set up the actions runner on their desktop just to be able to run local testing, and thus everyone who contributes to pgrx, including myself, is averse to refactoring them.

related:

  • https://github.com/pgcentralfoundation/pgrx/issues/1554
  • https://github.com/pgcentralfoundation/pgrx/issues/1565
  • https://github.com/pgcentralfoundation/pgrx/pull/1796

workingjubilee avatar Aug 09 '24 19:08 workingjubilee

act exists but word on the block is it kinda sucks. I'm guessing it has the problem of not actually being the same as the runner. It doesn't even seem to fully support the GHA yamlscript.

workingjubilee avatar Aug 09 '24 20:08 workingjubilee

Have you considered the way bevy went? It allows to run the exactly same thing both in the CI and locally: https://github.com/bevyengine/bevy/tree/release-0.14.2/tools/ci.

YohDeadfall avatar Sep 12 '24 18:09 YohDeadfall

@YohDeadfall That's basically my intention, yes.

workingjubilee avatar Sep 12 '24 20:09 workingjubilee