kobopatch-patches
kobopatch-patches copied to clipboard
Kepub constant font sharpness
In libnickel.so.1.0.0.yaml/geoffr.yaml, constant font sharpness patch is missing for KePubs. He left a comment in the file which reads:
MISSING: KePub constant font sharpness (not enough room for neutralizing the QString arg; we will probably need to patch that one out)
I don't quite understand it since I am able to do the patch and verify that it is actually working with screenshots. Have I missed anything? Also, I only edited version 4.34 and 4.35 because I have only tested these versions.
FYI, also note that you can safely remove the last semicolon in a CSS block, which could give you another character of space here.
Yeah, I am aware of that, I don't really think one would want that level of precision so I didn't do it. I would make the change anyways.
Also, I found that you could actually make the value more than 0.2 and it would still make a difference, but it would start eating away the actual font though. I would update the description for this discovery too.
This one looks safe enough to backport as long as the automated tests pass, so feel free to do so if you want.
Ok, I would check how far it backports to, but I don't think I would be running every version on my device myself though.