pg_query icon indicating copy to clipboard operation
pg_query copied to clipboard

Update CI to run against Ruby 3.3, drop Ruby 2.6

Open owst opened this issue 1 year ago • 4 comments

google-protobuf supports Ruby 3.3 in platform-specific versions of 3.25.3

Some discussion in this thread: https://github.com/protocolbuffers/protobuf/issues/15336#issuecomment-1946383093

owst avatar Mar 06 '24 13:03 owst

@owst Thanks for the contribution!

Looks like we do also need to bump up protobuf (at least a bit) to get this to work? (see failing CI)

lfittl avatar Mar 07 '24 01:03 lfittl

Oops, thanks for the ping @lfittl - I think my eyes read the gemspec requirement as already being >= 3.25.3 rather than >= 3.22.3 🤦

owst avatar Mar 07 '24 10:03 owst

Hmm, it looks like google-protobuf-3.25.3 doesn't support Ruby 2.6 (which is EOL) - I guess it's time to drop support for 2.6 in pg_query.

N.B. 2.7 is also EOL I wonder if by dropping support rubocop could be updated from its ancient version so it doesn't need to be skipped on PRs

owst avatar Mar 07 '24 23:03 owst

@lfittl any update on this?

For me it would make sense to drop support for Ruby 2.6, 2.7 and 3.0 since they are all EOL.

Additionally, I would consider adding a tool like Dependabot so that dependencies are not left too much behind here and so that we don't need to manually update them when needed.

WDYT?

Uaitt avatar Aug 14 '24 10:08 Uaitt

Thanks for your patience on this one!

lfittl avatar Nov 26 '24 22:11 lfittl