Simplify the BaseSchemUI state management
Use a separate custom hook for the Schema state management for:
- Simplify the SchemaView code
- Split the state management code in mode manageable & testable
- Make the state management reusable.
- Simplify the dependency management
In the latest snapshot, import export server dialog showing the loading icon and no error is in logs. But locally getting this error.
Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.
at SchemaDialogView (webpack:///./pgadmin/static/js/SchemaView/SchemaDialogView.jsx?:48:7)
at ErrorBoundary (webpack:///./pgadmin/static/js/helpers/ErrorBoundary.jsx?:23:5)
at SchemaView (webpack:///./pgadmin/static/js/SchemaView/SchemaView.jsx?:24:7)
Tested and verified on snapshot build: https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2024-08-13/ Package: arm64 Environment: macOs Ventura 13.5.1
Hi @asheshv Facing some issues with the below dialogs
- Filtered rows: When we open the dialog for any table and write the condition and click
Ok, it does not open View/Edit Data tool. - New Connection Dialog: In query tool, if we open new connection dialog, and it should by default load the server, database, role, also when selecting the server from the dropdown not able to show the selected server.
- Macro dialog: In query tool, If we open Manage macros and add a new macro or update any existing macro, the
Savebutton is not enabled. - User management dialog: In server mode, on adding a new user or updating a user does not enable the
Savebutton.
Hi @asheshv Here are some more issues I found.
- Sort/Filter Options dialog: In view/edit data tool, Click on the Sort/Filter icon, write condition or sort, save button is disabled.
- Debugger tool: Go to any function with arguments right click Debugging->Debug enter arguments the debug button remains disabled.
- Table>Index: create any index, by adding columns, giving something went wrong
- Table>Exclusion constraint: Create an exclusion constraint, and then add some columns/expressions, after adding the controls are not getting empty.
- Table>Foreign key: Create a foreign key, then add columns and references, once added the controls are not getting empty.
- Change password: After entering the details, Change is enabled but not working.
Hi @asheshv Here are some more issues I found.
- subscription dialog: after entering password, click on save, password is not going empty in API call.
- publication dialog: after entering tables, the dialog says Something went wrong .
- table dialog: constraints sections not working properly.
Tested and verified on candidate build: https://developer.pgadmin.org/builds/2024-08-19-1/ Package: arm64, pip wheel Environment: macOs Ventura 13.5.1