pgadmin4
pgadmin4 copied to clipboard
pgadmin-org
Patches for running in a flatpak
These are the needed patches we would need to be able to run pgadmin in a flatpak.
They stem of the work in https://github.com/flathub/flathub/pull/5105/files where we're doing this (much) worse with sed.
I think there might be a better solution for parts of this, but I'm not sure how to get there. Having this up-streamed at least would help us for the time being.
Unsure why the tests on macOS fail
You can ignore that. Its a JS test case, which is failing randomly.
@razzeee
Can you please raise a combined PR for this and https://github.com/pgadmin-org/pgadmin4/pull/7333?
@akshay-joshi would it be fine to cherry pick that into this branch?
I have cherry picked the commit.
This should be good to go, unless there was another release in the mean time.
Not sure, if you need to document/automate the addition of the release line in some way.
@razzeee You've made it compatible when running from flatpak. But the automated build process need to include flatpak build and publish it flatpak to flathub just like docker hub.
@razzeee You've made it compatible when running from flatpak. But the automated build process need to include flatpak build and publish it flatpak to flathub just like docker hub.
There's no way (for me) to publish it to flathub (and thus it doesn't make much sense to build the flatpak here) - you would need to reach out and ask for credentials. "Direct uploads" are a gated feature right now and I'm not sure, if @barthalion would allow your project into that test group.
The other way would be the repo on the flathub github, to manage the manifest. But that would ideally need this to be merged.
What I was asking about, was if there was automatic tooling generating the release notes/versions. Or if there are docs, that need to be extended to cover the process.
Hi @razzeee,
We are not planning to support the Flatpak packages yet, so it doesn't make sense to add the metainfo file to the repo. However, we can commit the path-related changes. Please remove the metainfo file from the PR so we can merge the remaining changes.
So you're saying, I should revert the combination of the two PRs and split this up again into the two PRs like it was at the start?
So you're saying, I should revert the combination of the two PRs and split this up again into the two PRs like it was at the start?
There is no point in raising a different PR for the meta info file because we are not going to commit that file. So, just remove that file from this PR so I can merge PATH-related changes, which are required for Flatpak.
We are not planning to support the Flatpak packages yet, so it doesn't make sense to add the metainfo file to the repo.
This assumption is incorrect. AppStream files are NOT specific to Flatpak in anyway. GNOME and KDE app ship them and they get installed by distro pacakge when they exists. It's then used by GNOME Software or KDE Discover or equivalent to show information about the app.
Hello @razzeee, we have reverted this commit as the pgAdmin app was crashing. Can you please open a new PR with the updated code?
Where did you do this? There is nothing linked here and you did not use the revert button in github.
Found it here https://github.com/pgadmin-org/pgadmin4/commit/dfaea944f024ab90139654957ff0ec8f6c17eb8c but it has no description, no reason etc. for all I can tell, this was arbitrary.
I guess I can just revert that code and put that into a new PR, but doubtful, that you want that.
Hi,
After merging the patch, pgAdmin 4 started hanging on the splash screen during the candidate build for release. Given the tight release schedule, we couldn't afford to wait for a proper fix. Therefore, we reverted the patch using "git revert
We haven't investigated the cause of the hang on the splash screen due to the urgency of the release.
Hi,
After merging the patch, pgAdmin 4 started hanging on the splash screen during the candidate build for release. Given the tight release schedule, we couldn't afford to wait for a proper fix. Therefore, we reverted the patch using "git revert ."
We haven't investigated the cause of the hang on the splash screen due to the urgency of the release.
This reads as in, you are not sure that it's even this commit, did you revert more? I'm trying to figure out, what your expectation for what I do in the new PR is.
Hi, After merging the patch, pgAdmin 4 started hanging on the splash screen during the candidate build for release. Given the tight release schedule, we couldn't afford to wait for a proper fix. Therefore, we reverted the patch using "git revert ." We haven't investigated the cause of the hang on the splash screen due to the urgency of the release.
This reads as in, you are not sure that it's even this commit, did you revert more? I'm trying to figure out, what your expectation for what I do in the new PR is.
Let me debug the code and investigate why pgAdmin hangs on splash screen. I'll give review comment on new PR.