[REGRESSION] Shift+Click in Results Grid not working to select multiple cells (RM #7628)

[dpage]

Issue migrated from Redmine: https://redmine.postgresql.org/issues/7628 Originally created by Jona Raphael at 2022-08-19 23:23:50 UTC.

Hello, I want to start off by expressing my gratitude for the work your team puts in--what a great thing you've created!

Recently, I updated my pgAdmin to the newest version (6.13), and was stymied by an apparent regression.

Previously, when you wanted to grab multiple results from the Query Tool Results Grid (e.g. for copying out of the application), you could do it many ways:

1. Click one or more headers to select whole columns
2. Click one or more indices to select whole rows
3. Click and drag to select adjacent cells
4. Click on one cell, then Shift+Click on another cell to select all intermediate cells

Now, options [1,2,3] still work, but option [4] is broken. Instead of selecting multiple, it only selects the second cell.

Is there any chance that this is a simple fix that you can patch quickly?

Best regards, Jona

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7628#note-1 Originally created by Aditya Toshniwal at 2022-08-22 05:22:44 UTC.

Hi Jona,

This is currently not supported, team will work on this. Reason is the new underlying grid lib does not support it yet.

Thanks.

Redmine ticket header update:

Name	Old Value	New Value
Priority changed	High	Normal

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7628#note-2 Originally created by Jona Raphael at 2022-08-23 06:18:44 UTC.

Thanks for the information!

Really looking forward to it becoming supported, again. Without this functionality, you are limited to what you can click-and-drag to select, BUT since the Results Grid doesn't scroll automatically when your mouse drags to the bottom (is this bug captured somewhere else?), you are limited to the small handful items that you can see on your screen at a time without scrolling! A very frustrating experience, to be sure. Do you have any sense of timeline--I'm afraid that without this function for more than a few weeks I'll have to download an older version again?

Additionally, while I'm not positive that "Cmd+Click" functionality existed in previous versions, it is definitely absent in this version. I assume this undesirable behavior is also due to the same reason the Shift+Click doesn't work. I'm eager to have "Cmd+Click" to select multiple cells again, too!

Best, Jona

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7628#note-3 Originally created by Khushboo Vashi at 2022-08-26 11:21:42 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Sprint changed		Ready

[jonaraphael]

Hoping that this might be feasible in the newest version? Any chance this feature request might see new life?

PS. Still grateful, and still a faithful user!

[KijongHan]

looks like this might be a possibility now as a result of this merged PR to the forked data grid library? https://github.com/pgadmin-org/react-data-grid/pull/7

[KijongHan]

hey there, I tried taking a stab at fixing this issue (working locally for me) - would appreciate any feedback on it to see if this can be resolved, thank you https://github.com/pgadmin-org/pgadmin4/pull/8554

[adityatoshniwal]

The rows/column range selection is fixed. Cell range selection is pending. I've created a separate issue for the same #8647

[anilsahoo20]

Hi @KijongHan,

Thanks for working on the bug. I was testing the nightly build with your fix and found a scenario i.e.

If I have columns like c1,c2,c3,c4,c5,c6,c7,c8,c9,c10. I click on c5 and shift+click on c10, then c5 to c10 gets selected and then if I shift+click on c8, c5 to c8 must be selected but c5 to c7 gets selected and it’s excluding c8. It must include the column c8, as it is the last selected column by the user.

Thanks

[KijongHan]

Hi @anilsahoo20 - thanks for testing out that scenario, I will try to get to investigating that scenario when my holiday is over this week.

[anilsahoo20]

Hi @KijongHan,

Thanks for working on the bug. I was testing the nightly build with your fix and found a scenario i.e.

If I have columns like c1,c2,c3,c4,c5,c6,c7,c8,c9,c10. I click on c5 and shift+click on c10, then c5 to c10 gets selected and then if I shift+click on c8, c5 to c8 must be selected but c5 to c7 gets selected and it’s excluding c8. It must include the column c8, as it is the last selected column by the user.

Thanks

Created a new issue for this scenario. #8713