[Query tool] react-data-grid issues and features (RM #7334)

[dpage]

Issue migrated from Redmine: https://redmine.postgresql.org/issues/7334 Originally created by Aditya Toshniwal at 2022-04-26 11:20:56 UTC.

Currently, react-data-grid component used does not allow to:

1. Shift + Arrow down to select rows.
2. Stop focus on other cell if a edited cell has error and click on other cell. Keyboard press can be prevented.

Need to work with upstream to raise issue and send PR if possible.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7334#note-1 Originally created by Aditya Toshniwal at 2022-04-29 05:20:36 UTC.

3. Allow to remove selected cell highlight.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7334#note-2 Originally created by Aditya Toshniwal at 2022-04-29 06:43:56 UTC.

Adding for reference - https://github.com/adazzle/react-data-grid/issues/2884

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7334#note-3 Originally created by Yogesh Mahajan at 2022-04-29 07:08:48 UTC.

Redmine ticket header update:

Name	Old Value	New Value
Relationship (relates) changed		RM #6131

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7334#note-4 Originally created by Frank Limpert at 2022-05-16 14:38:22 UTC.

• Entering data into the data grid using only the keyboard is a total kludge in version 6.9. I really hope you get this fixed soon.

• Another grief with the new data grid: If I inadvertently create a new record by clicking on the last, empty row, there is no way to get rid of that empty record. This is especially unpleasant if there are non-NULL constraints in the underlying table and you have entered more than one row already. The only way to get out of this situation at the moment is to start over.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7334#note-5 Originally created by Aditya Toshniwal at 2022-05-17 04:40:59 UTC.

Hi Frank,

Frank Limpert wrote:

• Entering data into the data grid using only the keyboard is a total kludge in version 6.9. I really hope you get this fixed soon.

Can you please describe the exact issue you're facing ?

• Another grief with the new data grid: If I inadvertently create a new record by clicking on the last, empty row, there is no way to get rid of that empty record. This is especially unpleasant if there are non-NULL constraints in the underlying table and you have entered more than one row already. The only way to get out of this situation at the moment is to start over. Are you using v6.9 ? We've removed the "last empty row" way of adding new rows from v6.9. Instead, a new button is added to add rows. And you remove a newly added row by selecting the row (by clicking on row number) and click on delete button.

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7334#note-6 Originally created by Jair dos Santos at 2022-05-25 22:05:18 UTC.

On entering data into the data grid using only the keyboard:

What I've noticed so far:

1. Enter no longer invokes a field's editor (a double click is required instead)

2. Ctrl+Enter no longer submits the edited contents to the field - it removes the editor but does not submit the change (clicking the Save button is required instead)

3. Ctrl+A no longer selects all the grid's contents (clicking on the top-left corner of the grid is required instead)

[dpage]

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7334#note-7 Originally created by Frank Limpert at 2022-05-26 17:50:40 UTC.

I can only confirm the previous poster. In the end, it should be possible to enter data into the grid using only the keyboard.

[nikhil-mohite]

Need to change in react-data-grid lib, which is used in Query Tool.