pgadmin4 icon indicating copy to clipboard operation
pgadmin4 copied to clipboard

Published 20 hours ago • verified publisher icon pgadmin-org

Usability issue with Macros (RM #6969)

Open dpage opened this issue 3 years ago • 11 comments

Issue migrated from Redmine: https://redmine.postgresql.org/issues/6969 Originally created by Dave Caughey at 2021-11-01 14:31:18 UTC.

I just started playing with macros, and have the following usability observations:

To create a macro, you should be able to right click on any displayed SQL (e.g., in the Query Tool or "View/Edit Rows") and click "Add to macros" (or "Create macro"), whereby you get prompted for the name and key binding (or just add it to the next free slot).

There should be a default name (e.g., "Macro 5") so the user doesn't have to pick an explicit name for each macro before they can save it. (Minor issue)

If you ever want to change the key bindings (e.g., swap CTRL+1 and CTRL+2 functionality), you have to manually rebuild both macros (e.g., type in the name and SQL for both). Either the key sequence should be editable, or there should be shift up/down keys to re-order them.

There is a limit of 22 macros (CTRL + 0-9, CTRL + F1-F12). There is no need for this limit, because there's actually no need to have a macro bound to a CTRL+ sequence. Most people will click on the Macros icon, look at the names, and pick the desired macro from the list, rather than blindly type CTRL+5 and hope that they remembered that their desired query was bound to CTRL+5 and not CTRL+6. Only the most commonly used macros will ever be invoked by a CTRL+ sequence.

The "Save" button in Manage Macros isn't enabled until focus is lost on an input. E.g., if I paste in some SQL, then click on the "Name" input and enter "My Macro" I still can't click Save, until I tab away from the Name input.

dpage avatar Nov 01 '21 14:11 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-1 Originally created by Aditya Toshniwal at 2021-11-12 11:36:13 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready

dpage avatar Nov 12 '21 11:11 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-2 Originally created by Akshay Joshi at 2022-01-05 09:10:45 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready EDB Sprint 108

dpage avatar Jan 05 '22 09:01 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-3 Originally created by Akshay Joshi at 2022-01-19 10:32:06 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 108 EDB Sprint 109

dpage avatar Jan 19 '22 10:01 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-4 Originally created by Akshay Joshi at 2022-01-26 17:21:22 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 109 EDB Sprint 110

dpage avatar Jan 26 '22 17:01 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-5 Originally created by Aditya Toshniwal at 2022-01-27 05:32:43 UTC.

Redmine ticket header update:

Name Old Value New Value
Relationship (relates) changed RM #6131

dpage avatar Jan 27 '22 05:01 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-6 Originally created by Akshay Joshi at 2022-02-16 10:24:26 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 110 Ready

dpage avatar Feb 16 '22 10:02 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-7 Originally created by Akshay Joshi at 2022-03-29 07:38:35 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready EDB Sprint 114

dpage avatar Mar 29 '22 07:03 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-8 Originally created by Akshay Joshi at 2022-03-29 07:52:30 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Aditya Toshniwal

dpage avatar Mar 29 '22 07:03 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-9 Originally created by Akshay Joshi at 2022-04-13 10:41:33 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 114 EDB Sprint 115

dpage avatar Apr 13 '22 10:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-10 Originally created by Akshay Joshi at 2022-04-13 10:48:55 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 115 Ready
Assigned To changed Aditya Toshniwal

dpage avatar Apr 13 '22 10:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/6969#note-11 Originally created by Akshay Joshi at 2022-04-13 10:52:25 UTC.

Some part has been fixed after porting the query tool to React. Revision b5b9ee46 (https://redmine.postgresql.org/projects/pgadmin4/repository/2/revisions/b5b9ee46a1f7aa9cc228e6c4c676da20c80a8260)

dpage avatar Apr 13 '22 10:04 dpage

@RohitBhati8269, I found one issue.

The Macros dialog opens but nothing is displayed, if I close the dialog and then again open contents are displayed. It displays content on alternate clicks. Attaching screen recording for ref:

https://github.com/pgadmin-org/pgadmin4/assets/111979571/a6a25511-32e6-4707-a713-b38dec50220e

pravesh-sharma avatar May 27 '24 07:05 pravesh-sharma

Issue fixed, Verified on candidate build.

Env: OS - Rocky 9 Mode - Desktop

pravesh-sharma avatar May 28 '24 09:05 pravesh-sharma