pgadmin4 icon indicating copy to clipboard operation
pgadmin4 copied to clipboard

The slider of the query result view is useless in case of long tables (RM #3269)

Open dpage opened this issue 6 years ago • 20 comments

Issue migrated from Redmine: https://redmine.postgresql.org/issues/3269 Originally created by bassi bass at 2018-04-11 09:17:35 UTC.

If I use the Slider on the right side of the result vies they would jump up if new lines are loaded. Then I have grab the slider again to navigate in the result set. This is very irritating if I navigate within long results. Going to the end of a long result with this way is nearly impossible.

dpage avatar Apr 11 '18 09:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-1 Originally created by Dave Page at 2018-04-27 10:49:32 UTC.

For a future release, if we can get the final row count without loading all the rows, then we could potentially adjust the scrollbar to reflect the correct number of rows from the outset. However, if we can't do this without loading all rows, then we'll leave it as-is.

However, a workaround if desired is to create a conflg_local.py file alongside pgAdmin's config.py file, and in there add a line such as:

ON_DEMAND_RECORD_COUNT = 10000000

This will make the batch load size 10M rows which in most sane cases will cause all rows to be loaded at once, so the scrollbar will be sized correctly, though of course that may effectively slow down result retrieval. Obviously the value used here can be adjusted to suit preferences.

dpage avatar Apr 27 '18 10:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-2 Originally created by Dave Page at 2018-04-27 10:50:18 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready

dpage avatar Apr 27 '18 10:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-3 Originally created by Aditya Toshniwal at 2020-03-06 11:54:21 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready squash

dpage avatar Mar 06 '20 11:03 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-4 Originally created by Nagesh Dhope at 2020-04-17 06:19:29 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Nagesh Dhope
Status changed New In Progress

dpage avatar Apr 17 '20 06:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-5 Originally created by Nagesh Dhope at 2020-04-21 08:00:31 UTC.

Applied in changeset commit:8d4f3c07c777d57cf0e89af8ed06b0e7886f37ab.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 0 90
Status changed In Progress In Testing

dpage avatar Apr 21 '20 08:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-6 Originally created by Akshay Joshi at 2020-04-21 08:02:48 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 4.21

dpage avatar Apr 21 '20 08:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-7 Originally created by Akshay Joshi at 2020-04-21 08:03:19 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Nagesh Dhope

dpage avatar Apr 21 '20 08:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-8 Originally created by Pradip Parkale at 2020-04-21 10:43:46 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Pradip Parkale

dpage avatar Apr 21 '20 10:04 dpage

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/4845 Originally created by Pradip Parkale at 2020-04-22 06:55:50 UTC.

Screenshot_2020-04-22_at_10.50.01_AM.png

Filename: Screenshot_2020-04-22_at_10.50.01_AM.png

dpage avatar Apr 22 '20 06:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-10 Originally created by Pradip Parkale at 2020-04-22 07:16:29 UTC.

Hi Nagesh,

I have tested this on the latest snapshot build https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2020-04-22/.

I created a table with 1000100 entries and hit select * from table then few rows get loaded and others were showing 'loading', I waited around an hour but no new row was loaded.

Please see the attached screenshot.

Redmine ticket header update:

Name Old Value New Value
Status changed In Testing New
Attachment added Screenshot 2020-04-22 at 10.50.01 AM.png

dpage avatar Apr 22 '20 07:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-11 Originally created by Pradip Parkale at 2020-04-22 07:25:51 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Pradip Parkale

dpage avatar Apr 22 '20 07:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-12 Originally created by Nagesh Dhope at 2020-04-22 07:28:41 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Nagesh Dhope
Status changed New In Progress

dpage avatar Apr 22 '20 07:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-13 Originally created by Nagesh Dhope at 2020-04-22 13:17:27 UTC.

Applied in changeset commit:5e91ed2bb1123b7bc7a96ee783d50b8b8b2f716b.

Redmine ticket header update:

Name Old Value New Value
Status changed In Progress In Testing

dpage avatar Apr 22 '20 13:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-14 Originally created by Akshay Joshi at 2020-04-22 13:21:32 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Nagesh Dhope

dpage avatar Apr 22 '20 13:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-15 Originally created by Shubham Agarwal at 2020-04-23 05:57:42 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Shubham Agarwal

dpage avatar Apr 23 '20 05:04 dpage

Image migrated from Redmine: https://redmine.postgresql.org/attachments/download/4853 Originally created by Shubham Agarwal at 2020-04-23 06:00:15 UTC.

Screenshot_2020-04-23_at_11.27.24_AM.png

Filename: Screenshot_2020-04-23_at_11.27.24_AM.png

dpage avatar Apr 23 '20 06:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-17 Originally created by Shubham Agarwal at 2020-04-23 06:00:38 UTC.

The values are not getting loaded after 2000 rows. Attached is the screenshot.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Shubham Agarwal Nagesh Dhope
Status changed In Testing In Progress
Attachment added Screenshot 2020-04-23 at 11.27.24 AM.png

dpage avatar Apr 23 '20 06:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-18 Originally created by Akshay Joshi at 2020-04-24 05:48:42 UTC.

Reverting patch for RM #3269.

We observed that sometimes the browser is getting hanged and sometimes the ViewData grid is getting disappear. We suspect its due to the number of rows to update on the slick grid after fetching next of rows.

Redmine ticket header update:

Name Old Value New Value
Sprint changed squash Ready
Done Ratio changed 90 0
Fixed Version changed 4.21
Assigned To changed Nagesh Dhope
Status changed In Progress New

dpage avatar Apr 24 '20 05:04 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-19 Originally created by Akshay Joshi at 2022-05-11 09:54:24 UTC.

Need to discuss.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready

dpage avatar May 11 '22 09:05 dpage

Comment migrated from Redmine: https://redmine.postgresql.org/issues/3269#note-20 Originally created by Nikhil Mohite at 2022-05-13 11:24:01 UTC.

We can try something like this: https://codepen.io/ykadosh/pen/ZdxeYY We can insert the total number of rows as dummy and load data based on the scroll.

Redmine ticket header update:

Name Old Value New Value
Sprint changed Ready

dpage avatar May 13 '22 11:05 dpage

We've decided to replace infinite scrolling with pagination for better UX.

adityatoshniwal avatar Aug 29 '24 12:08 adityatoshniwal

Feature implemented and is working fine. Tested on snapshot build.

Env: OS - macOS 14.7 (Sonoma) Mode - Desktop

pravesh-sharma avatar Oct 03 '24 12:10 pravesh-sharma