pgScorpio

Results 89 comments of pgScorpio

> Could you please add a CHANGELOG entry in your PR description (and a short reasoning why you need this + advantages e.g uniform way to show error messages in...

Questions: Do we want a "Jamulus [clientname]" prefix to appear on the debug steams too? (Personally I think this might be usefull.) Would it be useful to be able to...

> I'm less sure about the headless stuff. My gut feeling is that there are not that many instances where there's duplicated error handling for UI/CLI stuff, but I might...

> > Would it be useful to be able to set the button text from the "ShowXxxx" calls (optional parameter defaulting to "Ok")? > > Overload the methods to add...

@hoffie > I'm not entirely convinced whether it's better to re-use and overload this existing protocol message (it's related, but the original meaning is different) or whether to add a...

> Re opening to allow discussion for @pgScorpio Thanks @ann0see, I didn't notice this issue until now. (Since this subject is discussed in multiple places we maybe better start a...

@pljones > https://github.com/pljones/jamulus/tree/feature/next-big-thing-for-settings/src https://github.com/pljones/jamulus/blob/feature/next-big-thing-for-settings/src/options.h https://github.com/pljones/jamulus/blob/feature/next-big-thing-for-settings/src/options.cpp I'm aware of your work on settings and commandline options, and I already asked you multiple times to work on this together (until now, unfortunately...

@ann0see > I think it is possible to have a PR with only the class and some mi or code changes? As a matter of fact this can be implemented...

@pljones > I'm working on that. I already have it in my own jamulus repo and I would like to push it but, again, I don't know how to open...

@ann0see Wednesday evenings I have my choir rehearsals, any other evening I'm available most of the time though.