pgrouting icon indicating copy to clipboard operation
pgrouting copied to clipboard

Recover macos test

Open sanak opened this issue 1 year ago • 0 comments

Related with PR #2619.

Changes proposed in this pull request:

  • Recover macos test
    • Update homebrew path after macOS Intel => Silicon update.

Example CI results:

  • Before:
    • Job: https://github.com/sanak/pgrouting/actions/runs/9336541789
    • Total duration: 30m 6s
  • After:
    • Job: https://github.com/sanak/pgrouting/actions/runs/9336551609
    • Total duration: 37m 18s
    • Test summary: https://github.com/sanak/pgrouting/actions/runs/9336551609/job/25697256003#step:7:41034

@pgRouting/admins

sanak avatar Jun 02 '24 08:06 sanak

This is why when I added it, I added an option to turn it off. You're right that this functionality does a which with each character typed. I thought about caching it but then it gets quite a bit more complicated because you have to know when to invalidate the cache and re-cache every command. You also have to know how much memory to use and limit it somehow because now you're holding a list of every accessible executable in memory all the time.

I don't think there is a nushell command that works cross-platform that tells you when you're on battery power or not. If you had one with your OS, you could setup an env_change hook or something like that to turn the config setting off.

fdncred avatar Jun 17 '24 16:06 fdncred

Yeah, I figured as much. It's always tricky to determine those requirements. I will look into doing an env_change hook for the time being.

Is there any way to override the which command that is getting called when that variable is set to true. I suppose there is a worry that someone might abuse that, but could be an opportunity for users to have their own custom logic?

nblum-mdmi avatar Jun 17 '24 17:06 nblum-mdmi

The only option right now is to set $env.config.highlight_resolved_externals to false to disable it or true to enable it.

There are some factors that influence the performance though. If you have a HDD it would be good to have it regularly defragged. The fewer folders in your path, the faster it should run.

fdncred avatar Jun 17 '24 17:06 fdncred