docker-pgrouting icon indicating copy to clipboard operation
docker-pgrouting copied to clipboard

Remove CGAL from v3

Open cayetanobv opened this issue 5 years ago • 6 comments

Remove CGAL from v3 image according to: https://github.com/pgRouting/pgrouting/pull/1188

cayetanobv avatar Feb 27 '19 15:02 cayetanobv

I think we can now remove CGAL from Dockerfile templates but we can not generate more pre-v3 versions. What do you think about it?

CC: @dkastl @aruneko @cvvergara @smellman @sanak

cayetanobv avatar Jun 30 '20 11:06 cayetanobv

@cayetanobv Well, how about to use Dockerfile ARG variable to support both v3 and pre-v3 versions ?
In quite old pgRouting version (2.0), there was -DWITH_DD cmake flag, but in recent case, something like INSTALL_CGAL flag may be good.

+ ARG INSTALL_CGAL=FALSE
:
+ && if [ "${INSTALL_CGAL}" = "TRUE" ]; then apt install -y libcgal%%CDAL_VERSION%% libcgal-dev; fi \

(By the way, CDAL_VERSION should be changed to CGAL_VERSION ?)

I think that -DCMAKE_BUILD_TYPE support may be also interesting. (But, not sure how changing build type affect performance.)

sanak avatar Jul 05 '20 16:07 sanak

@sanak LGTM

cayetanobv avatar Jul 07 '20 12:07 cayetanobv

@cayetanobv Okay, thanks for confirmation.

sanak avatar Jul 07 '20 15:07 sanak

@cayetanobv (CC: @cvvergara) Related with #50, now I think that removing CGAL is no problem.

Here is some related news. https://github.com/pgRouting/pgrouting/issues/1345#issuecomment-1128165167

sanak avatar Jun 29 '22 22:06 sanak

Yes, I think so

cayetanobv avatar Jun 30 '22 13:06 cayetanobv

I removed CGAL in PR:#55 (commit:https://github.com/pgRouting/docker-pgrouting/pull/55/commits/be23190bc21ffad28de9dc0d1384fd2350a115d1), so I close this.

sanak avatar Aug 02 '24 01:08 sanak