docker-pgrouting icon indicating copy to clipboard operation
docker-pgrouting copied to clipboard

Tag name convention

Open dkastl opened this issue 7 years ago • 11 comments

@cayetanobv , I saw that you were trying a few different ways to name the tags.

What if we would follow the way Debian packages are named? For example: https://packages.debian.org/sid/hppa/postgresql-10-pgrouting/download

The package name starts with postgresql-{version} followed by -pgrouting_version.

dkastl avatar Oct 18 '18 09:10 dkastl

Hi @dkastl , I'm not totally convinced of current tag naming system but I couldn't find another that "sounds" better :) We can discuss how to improve (and of course make a change in the current system) but we shoud take in consideration that Docker image naming system is the following:

{organization_name}/{repository_name}:{tag}

Example with current naming system:

pgrouting/docker-pgrouting:pg_10_2.6.1

Example with debian based naming system:

pgrouting/docker-pgrouting:postgresql-10-pgrouting-2.6.1

It is a little bit long but it sounds good and maybe it is more clear for people.

On the other hand I make a mistake with Docker repository name. It must be "pgrouting" and not "docker-pgrouting" (which is the github repository name). Ups.... I think I need to delete and recreate...

UPDATE: when I change Docker repository name the example will be the following:

pgrouting/pgrouting:postgresql-10-pgrouting-2.6.1

cayetanobv avatar Oct 18 '18 11:10 cayetanobv

OK, feel free to recreate it. And I understand, that tag names would be become a bit long.

How about starting with the pgRouting release number followed by PostgreSQL:

pgrouting/pgrouting:v2.6.1-psql_10

or with full name for postgresql

pgrouting/pgrouting:v2.6.1-postgresql_9.6

dkastl avatar Oct 18 '18 12:10 dkastl

I like your ideas @dkastl . I'm going to recreate Docker repository so this is the moment to change naming system :) I choose second proposal (full name for postgresql) because psql could be confusing with CLI tool.

cayetanobv avatar Oct 18 '18 15:10 cayetanobv

pgrouting is used for pgrouting https://github.com/pgRouting/pgrouting

cvvergara avatar Oct 21 '18 00:10 cvvergara

@cvvergara this change is only for Docker repository not for Github repository. Github reposity remains as "docker-pgrouting".

cayetanobv avatar Oct 21 '18 14:10 cayetanobv

ah, I didnt know docker has repositories, so much for my docker knowledge ;)

cvvergara avatar Oct 21 '18 14:10 cvvergara

Builded images with new tags. New repository created.

cayetanobv avatar Oct 22 '18 07:10 cayetanobv

@cayetanobv How are you handling the changes that are taking place on v3.0.0-dev, almost everyday there is a PR?

cvvergara avatar Oct 24 '18 23:10 cvvergara

There should be a way to automate this, but I had to study a bit how to set this up. Anyone knows how to do? https://docs.docker.com/docker-hub/github/#github-organizations

dkastl avatar Oct 24 '18 23:10 dkastl

I will open another issue with this topic change.

cvvergara avatar Oct 24 '18 23:10 cvvergara